Missing some type information on hover (literals, type constructors, ...)

[ConnorBaker]

Hi all,

I noticed a difference in behavior between HIE and HLS, and I wasn't sure if this is intended or something we're all aware of.

This is all done on a fresh install of VS Code, using the latest version of the Haskell plugin, on macOS Catalina 10.15.6.

Ignore the HLint suggestions HIE has -- I'm aware that's not a feature that's been merged.

I set up the project by running

stack new mwe simple --resolver lts

I've put the log the extension generates with HLS at the end. I didn't see any output from HIE so I didn't attach it.

Hovering over Test1 with HIE:

Hovering over Test1 with HLS:

Hovering over "hello world" with HIE:

Hovering over "hello world" with HLS:

Some of the stuff is the same, as expected, like hovering over putStrLn.

Hovering over putStrLn with HIE:

Hovering over putStrLn with HLS:

Any ideas as to what could be causing this? Anything I can do to further debug or test this?

Here's the log from the extension when using HLS:

[client] run command: "/Users/connorbaker/Library/Application Support/Code/User/globalStorage/haskell.haskell/haskell-language-server-0.2.2-darwin-8.8.3 --lsp"
[client] debug command: "/Users/connorbaker/Library/Application Support/Code/User/globalStorage/haskell.haskell/haskell-language-server-0.2.2-darwin-8.8.3 --lsp"
[client] server cwd: undefined
haskell-language-server version: 0.2.2.0 (GHC: 8.8.3) (PATH: /Users/connorbaker/Library/Application Support/Code/User/globalStorage/haskell.haskell/haskell-language-server-0.2.2-darwin-8.8.3) (GIT hash: e44f618c11b7978264a94beeee00d1f014867f6d)
Starting (haskell-language-server)LSP server...
  with arguments: LspArguments {argLSP = True, argsCwd = Nothing, argFiles = [], argsShakeProfiling = Nothing, argsTesting = False, argsExamplePlugin = False, argsDebugOn = False, argsLogFile = Nothing, argsThreads = 0, argsProjectGhcVersion = False}
  with plugins: [PluginId "eval",PluginId "floskell",PluginId "ghcide",PluginId "ormolu",PluginId "pragmas",PluginId "stylish-haskell"]
  in directory: /Users/connorbaker/Downloads/mwe
If you are seeing this in a terminal, you probably should have run ghcide WITHOUT the --lsp option!
 Started LSP server in 0.00s
2020-08-03 16:39:34.594322 [ThreadId 21] - Opened text document: file:///Users/connorbaker/Downloads/mwe/src/Main.hs
Data.HashMap.Base.(!): key not found
CallStack (from HasCallStack):
  error, called at ./Data/HashMap/Base.hs:733:16 in nrdrd-cntnrs-0.2.11.0-ba87ae8b:Data.HashMap.Base
  !, called at src/Development/IDE/Import/DependencyInformation.hs:107:40 in ghcide-0.2.0-inplace:Development.IDE.Import.DependencyInformation
2020-08-03 16:39:34.596038 [ThreadId 63] - Consulting the cradle for "/Users/connorbaker/Downloads/mwe/src/Main.hs"
Output from setting up the cradle Cradle {cradleRootDir = "/Users/connorbaker/Downloads/mwe", cradleOptsProg = CradleAction: Stack}
> Using main module: 1. Package `mwe' component mwe:exe:mwe with main-is file: /Users/connorbaker/Downloads/mwe/src/Main.hs
> Building all executables for `mwe' once. After a successful build of all of them, only specified executables will be rebuilt.
> mwe> configure (exe)
> Configuring mwe-0.1.0.0...
> mwe> initial-build-steps (exe)
> Configuring GHCi with the following packages: mwe
> /Users/connorbaker/Downloads/mwe/.stack-work/install/x86_64-osx/f3d7483496dd8bd90f069c026d66fa8f7f184c590d840d181d13ec2d62e0b560/8.8.3/pkgdb:/Users/connorbaker/.stack/snapshots/x86_64-osx/f3d7483496dd8bd90f069c026d66fa8f7f184c590d840d181d13ec2d62e0b560/8.8.3/pkgdb:/Users/connorbaker/.stack/programs/x86_64-osx/ghc-8.8.3/lib/ghc-8.8.3/package.conf.d
2020-08-03 16:39:38.580001 [ThreadId 63] - Using interface files cache dir: /Users/connorbaker/.cache/ghcide/main-d8d05e9ca6b2f9e9fbfedc994b318ed9989f8938
2020-08-03 16:39:38.580159 [ThreadId 63] - Making new HscEnv[main]
2020-08-03 16:39:38.589479 [ThreadId 141] - Plugin.makeCodeLens (ideLogger)
2020-08-03 16:39:38.623886 [ThreadId 191] - finish: codeLens (took 0.03s)
2020-08-03 16:40:48.511579 [ThreadId 194] - DocumentHighlight request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:48.758912 [ThreadId 197] - finish: CodeAction (took 0.00s)
2020-08-03 16:40:49.038359 [ThreadId 203] - finish: CodeAction:PackageExports (took 0.28s)
2020-08-03 16:40:50.610202 [ThreadId 206] - GhcIde.hover entered (ideLogger)
2020-08-03 16:40:50.61034 [ThreadId 206] - Hover request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:55.776118 [ThreadId 218] - Definition request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:55.933316 [ThreadId 221] - GhcIde.hover entered (ideLogger)
2020-08-03 16:40:55.933454 [ThreadId 221] - Hover request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:56.670498 [ThreadId 224] - GhcIde.hover entered (ideLogger)
2020-08-03 16:40:56.670626 [ThreadId 224] - Hover request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:56.813711 [ThreadId 227] - Definition request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:56.96864 [ThreadId 230] - GhcIde.hover entered (ideLogger)
2020-08-03 16:40:56.969035 [ThreadId 230] - Hover request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:40:57.357611 [ThreadId 233] - GhcIde.hover entered (ideLogger)
2020-08-03 16:40:57.357854 [ThreadId 233] - Hover request at position 3:17 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:06.32546 [ThreadId 236] - GhcIde.hover entered (ideLogger)
2020-08-03 16:41:06.325645 [ThreadId 236] - Hover request at position 7:19 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:06.433283 [ThreadId 239] - DocumentHighlight request at position 7:20 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:06.677143 [ThreadId 215] - finish: CodeAction (took 0.00s)
2020-08-03 16:41:06.677264 [ThreadId 215] - finish: CodeAction:PackageExports (took 0.00s)
2020-08-03 16:41:06.716227 [ThreadId 245] - GhcIde.hover entered (ideLogger)
2020-08-03 16:41:06.716484 [ThreadId 245] - Hover request at position 7:19 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:12.849835 [ThreadId 248] - GhcIde.hover entered (ideLogger)
2020-08-03 16:41:12.850065 [ThreadId 248] - Hover request at position 7:20 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:21.419129 [ThreadId 251] - GhcIde.hover entered (ideLogger)
2020-08-03 16:41:21.419245 [ThreadId 251] - Hover request at position 7:5 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:21.648557 [ThreadId 254] - DocumentHighlight request at position 7:6 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs
2020-08-03 16:41:21.896774 [ThreadId 215] - finish: CodeAction (took 0.00s)
2020-08-03 16:41:21.896906 [ThreadId 215] - finish: CodeAction:PackageExports (took 0.00s)
2020-08-03 16:41:21.989064 [ThreadId 260] - GhcIde.hover entered (ideLogger)
2020-08-03 16:41:21.98927 [ThreadId 260] - Hover request at position 7:6 in file: /Users/connorbaker/Downloads/mwe/src/Main.hs

[jneira]

Confirmed: hie shows info in type constructors and literals and hls (and ghcide i guess) does not. I am gonna label this an enhancement cause afaik this is the expected behaviour right now. But i think hie info is better.

[georgefst]

I've just noticed that I get this info on GHC 8.10 but not 8.8.

[ConnorBaker]

As @georgefst pointed out above (thank you!), it seems like this is working with the newest version, so I'm going to close this issue.

[jneira]

@ConnorBaker if you dont mind, i would keep it open as it does not work for ghc-8.8 and some users could miss that info.