Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Add 8.4.4 to the Windows-friendly make script #931

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

fsoikin
Copy link
Contributor

@fsoikin fsoikin commented Nov 9, 2018

No description provided.

@lorenzo
Copy link
Collaborator

lorenzo commented Nov 9, 2018

Thanks!

I'll merge this right away since it looks good to me and there is no need for waiting for the CI to pass on this change.

@lorenzo lorenzo merged commit fb980e4 into haskell:master Nov 9, 2018
@fsoikin
Copy link
Contributor Author

fsoikin commented Nov 9, 2018

Thanks for merging @lorenzo

I also wanted to ask about this: I'm very interested in this whole thing working on Windows, and I'd be willing to put some hours towards it.

In particular, this .bat tingles my spidey sense, it could be written in PowerShell (which is the current Windows shell of choice) much more elegantly and DRY. Would you be interested in that?

In addition, the main readme offers a way to build on Windows by installing make and running make build-all, but that doesn't really work, since Windows executables have the .exe extension, but Makefile refers to them by the UNIX extension-less names. Is that something that was missed, or am I the one who is missing something?

@fsoikin fsoikin deleted the make-on-windows branch November 9, 2018 19:17
@lorenzo
Copy link
Collaborator

lorenzo commented Nov 9, 2018

@fsoikin Definitely, that would be great to have!

Is that something that was missed?

Most likely, since most of use are not currently using windows. It will be really helpful if you could help us fixing those oversights.

@fsoikin
Copy link
Contributor Author

fsoikin commented Nov 9, 2018

Great, thank you @lorenzo !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants