-
Notifications
You must be signed in to change notification settings - Fork 209
Fix some hlint warnings #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some hlint warnings #1056
Conversation
andreasabel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99.9% of the suggestions are for the better! (For the rest, see my comments.)
You got my blessing! (Assuming these rewrites are correct.)
|
Thanks for the thorough review Andreas. @jhrcek feel free to take into account the suggestions or not. When you're ready for a merge, let me know. |
|
Thank you for reviews, I consider this ready to merge. |
|
I should add btw that the hlint changes are pretty minor as such, but since github was running them on every PR, cleaning up that noise really made development nicer. Thanks! |
Thanks for the feedback. I wasn't really sure if hlint fixes would be welcome by the maintainers, so I only fixed relatively conservative subset of warnings that I thought would be accepted by most people as obvious improvements. Anyway if you agree I will open followup PR, fixing more hlint warnings that make sense to be fixed. |
Yes, I think this is very important. I have some bad experiences with some external contributor pushing some hlint-suggested refactorings into the Agda code base, and some had quite negative effects on code readability. This is why I looked at each and every of your hlint-suggested changes in this PR and checked whether it aids readability.
Er, we get a lot of noise from GHC warnings (deprecated imports, incompleted pattern matching) but I do not think we have a hlint workflow afaik, so maybe @gbaz confused these two.
That sounds reasonable. That said, I am happy to look at another round of likely-not-controversial hlint refactorings. |
|
right -- i confused the two because there are other codebases that do toss hlint warnings at me. whoops :-) It would be nice to fix the ghc warnings for pattern matching as well I suppose, although doing it "right" would certainly take a bit of thought. |
Those should be fairly easy to work around. I will look at fixing those tomorrow. |
I'd like to contribute some more substantial fixes in the near future, but first please allow me to fix bunch of inconsequential hlint warnings, mostly just removing unused / unnecessary stuff