Skip to content

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Dec 29, 2021

No description provided.

@Mikolaj
Copy link
Member Author

Mikolaj commented Dec 29, 2021

There are test failures, e.g., https://github.com/haskell/hackage-security/runs/4660581702

Edit: and also compilation failures, e.g., https://app.travis-ci.com/github/Mikolaj/hackage-security/jobs/553802305
Edit2: but the newest GHC is fails with is 8.2.2 that was released on July 2017, which is beyond the 3-years cabal-install compatibility window (Cabal doesn't use hackage-security). See https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md

@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 8, 2022

Compilation failures on GHC 8.2 are caused by streaming-commons, it has been already updated. If you rerun, they'll be gone.

@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 8, 2022

Test failures are because of aeson-1.5, which no longer accepts unescaped control sequences:

    prop_aeson_canonical:            FAIL
      *** Failed! Falsified (after 8 tests and 3 shrinks):
      JSString "\n"
      Left "Error in $: Failed reading: unescaped control character" /= Right (String "\n")
      Use --quickcheck-replay=254160 to reproduce.
      Use -p '/prop_aeson_canonical/' to rerun this test only.

This is expected, because comments for renderCanonicalJSON state:

-- NB: Canonical JSON's string escaping rules deviate from RFC 7159
-- JSON which requires

I guess the test should be amended.

@Mikolaj
Copy link
Member Author

Mikolaj commented Jan 8, 2022

Thank you so much, @Bodigrim. I will amend the tests next week and we should be fine.

@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 8, 2022

As a Hackage trustee I made a revision relaxing template-haskell bounds. Otherwise earlier revisions, relaxing base, do not help to compile with newer GHCs. Please include it into this PR.

@Mikolaj
Copy link
Member Author

Mikolaj commented Jan 8, 2022

Hah, I already forgot what the purpose of this exercise is. ;D

@Mikolaj Mikolaj merged commit cf8f1da into haskell:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants