Fix #8141 Don't refer to 'custom-setup' as 'optional' #9905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Apr 17, 2024
Also uses 'stanza' consistently in that context.
ulysses4ever
approved these changes
Apr 19, 2024
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Not sure how consistent we are w.r.t. section vs. stanza in general, but I particularly like wording of the first of the three hunks in this diff (the required for build-type Custom bit).
mergify
bot
added
the
merge delay passed
Collaborator
|
documentation fix -- backporting |
Collaborator
|
@mergify backport 3.12 |
Contributor
✅ Backports have been created
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uses 'stanza' consistently in that context.
See #8141.