Rebase #5440: Respect ghc-options and with-gcc when compiling C sources #7874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows users to override the C/C++ compiler, either by passing --with-gcc to configure or adding -pgmc to ghc-options in their Cabal file. Tested manually with a project using C++ sources that require a more recent version of clang than the default install (macOS). Inspected the output of `Setup.hs build -v` to confirm that the correct arguments are being passed to GHC when compiling the C++ sources. Resolves: haskell#4439
Member
|
@jberryman: thank you so much! Any volunteer to add a simple test for that? |
Mikolaj
approved these changes
Dec 22, 2021
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
LGTM, but I think we really need to test this. Ideally by adding a simple test. Trying out reproducing problems that people had that prompted this would would also be great. Perhaps we can ask them to try out the branch?
This was referenced Dec 22, 2021
Member
|
I did ask them. Let's wait some longer, given that it's Christmas and New Year. |
mergify bot
added a commit
that referenced
this pull request
Jan 12, 2022
Update #7874: Add test, fix changelog
Member
|
@jberryman: thank you for #7900, which is now merged, which ends the saga! Please, everybody, test and reopen if anything doesn't work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #5440 rebased on master
I don't understand the patch well enough to really help further right now. Please close if this isn't mergeable.