-
Notifications
You must be signed in to change notification settings - Fork 723
MAINTAINERS.md: add emails and PGP keys #11271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ffaf1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
Matthew and Artem keys lack cross signatures, which I plan to rectify.
Matthew email is not present on his key, which is fine but let me ping him to make 100% sure we got the correct key.
|
thank you Francesco, I hoped that someone would assess these critically since I just took what I could quickly google for. Matt's key is especially suspicious I agree. |
|
Forgot the ping, @mpickering |
|
As far as I'm aware, I don't have a PGP key. |
|
all right, we can skip the key for Matthew for now, maybe? |
Removed the PGP key from Matthew Pickering's entry.
|
You probably don't want to use fixups any more unless you squash manually: Mergify is dropping support for autosquash. |
|
@geekosaur we've discussed it before (maybe several times): I use fixups not because of support from Mergify but because it's how I'm used to format fixup commits. |
this fixes #11245
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: