Skip to content

Conversation

@ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Nov 7, 2025

this fixes #11245


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

Matthew and Artem keys lack cross signatures, which I plan to rectify.

Matthew email is not present on his key, which is fine but let me ping him to make 100% sure we got the correct key.

@ulysses4ever
Copy link
Collaborator Author

thank you Francesco, I hoped that someone would assess these critically since I just took what I could quickly google for. Matt's key is especially suspicious I agree.

@ffaf1
Copy link
Collaborator

ffaf1 commented Nov 7, 2025

Forgot the ping, @mpickering

@mpickering
Copy link
Collaborator

As far as I'm aware, I don't have a PGP key.

@ulysses4ever
Copy link
Collaborator Author

all right, we can skip the key for Matthew for now, maybe?

Removed the PGP key from Matthew Pickering's entry.
@ulysses4ever ulysses4ever added the squash+merge me Tell Mergify Bot to squash-merge label Nov 7, 2025
@geekosaur
Copy link
Collaborator

You probably don't want to use fixups any more unless you squash manually: Mergify is dropping support for autosquash.

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Nov 7, 2025
@ulysses4ever
Copy link
Collaborator Author

@geekosaur we've discussed it before (maybe several times): I use fixups not because of support from Mergify but because it's how I'm used to format fixup commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-review ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to verify which signing key to use

6 participants