Skip to content

Conversation

@ulysses4ever
Copy link
Collaborator

I have backports failing on 3.12 because the index state update from #9897 is not on 3.12: https://github.com/haskell/cabal/actions/runs/9080152427/job/24950912901?pr=10002

Does it look reasonable to backport this change? @ffaf1 @Mikolaj


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ulysses4ever ulysses4ever requested review from Mikolaj and ffaf1 May 14, 2024 15:00
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the bumped index has been tested enough on master by now. Am I missing any other problems with that bump?

@ulysses4ever
Copy link
Collaborator Author

I hope not. My worry is that #9897 is big and some other changes in it may need to be backported as well.

@Mikolaj
Copy link
Member

Mikolaj commented May 14, 2024

I hope not. My worry is that #9897 is big and some other changes in it may need to be backported as well.

IIRC a big part of that was boostrap fixes and then there was a followup PR of precisely that. This is a nightmare to debug and 3.12 will never be used for boostrapping, so I'd propose not to try to update bootstrapping and if it starts failing due to other changes (e.g., version bumps), just disable it in CI.

Edit: or at least in theory we provide boostraps only on master branch. I hope users don't try to use others.

@ulysses4ever ulysses4ever added backport merge me Tell Mergify Bot to merge labels May 14, 2024
@Mikolaj Mikolaj force-pushed the ulysses4ever/bp/3.12/pr-9897 branch from d59838a to 347ccbc Compare May 14, 2024 22:27
@mergify mergify bot merged commit 6ee1b0a into 3.12 May 15, 2024
@mergify mergify bot deleted the ulysses4ever/bp/3.12/pr-9897 branch May 15, 2024 01:07
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants