stdcall attributes in function pointers #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extractCallingConvention function should check for any calling convention attributes inside function pointer declarators.
Dynamic foreign imports are generated by c2hs whenever C function pointers need to be called. Function pointer declarations may contain attributes which specify a calling convention to be used. This patch Applies changes made in a3ac24e1c7d3f2ec542364643f4346caba1a4915 to the case of "dynamic" foreign imports.
|
Thanks! I'll look at this in the next couple of days. |
|
@mikesteele81 This looks good. Thanks! I need to make sure that the regression suite I run on Travis works OK, but I can't see any reason that it shouldn't. I don't do any testing on Windows myself, so I'm relying on you for that! |
|
Thanks for pulling this. I'm working on a binding where C structures containing function pointers need to be called from Haskell. C2hs's code base is unfamiliar to me, so I wasn't certain that these changes would have the intended effect without causing problems elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix #88.