Skip to content

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Nov 1, 2021

@sjakobi
Copy link
Member Author

sjakobi commented Nov 1, 2021

I was wondering whether we should update constraints like (Eq k, Hashable k). @phadej has convinced me not to do this for now in haskell-unordered-containers/hashable#232 (comment). Instead, we can consider requiring hashable >= 1.4 in a few months and enabling -Wredundant-constraints then.

@sjakobi
Copy link
Member Author

sjakobi commented Nov 2, 2021

Ping @treeowl. I'd like to make a release including this patch soon.

@phadej
Copy link
Contributor

phadej commented Nov 5, 2021

I checked that CI indeed picks up hashable-1.4.0.0 as a dependency. Ping @treeowl .

In the meantime, @sjakobi do you mind adding 9.2.1 job to CI? EDIT: looks like it is added in master, but this PR is not on top of ci-job-adding commit?

@treeowl
Copy link
Collaborator

treeowl commented Nov 5, 2021

Sounds like a plan.

@sjakobi sjakobi merged commit 23303a6 into master Nov 7, 2021
@sjakobi sjakobi deleted the sjakobi/hashable-1.4 branch November 7, 2021 04:27
@sjakobi
Copy link
Member Author

sjakobi commented Nov 7, 2021

@phadej I've checked locally that this branch builds with GHC 9.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants