Added dispatch and stop to the job abstraction for api requests #9
Conversation
|
As I see, nomad-ruby not supported because there is missing methods not only for dispatch and stop but for job versions, that's why spec for read job not working fails |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 0 out of 2 committers have signed the CLA.
Mike seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
drewbailey
left a comment
drewbailey
left a comment
There was a problem hiding this comment.
Thanks for this contribution! Do you mind adding integration tests for dispatch and stop? The Job integration specs can be found here https://github.com/hashicorp/nomad-ruby/blob/master/spec/integration/api/job_spec.rb
| # dispatch job meta parameters | ||
| # | ||
| # @return [JobDispatch] | ||
| def dispatch(name, payload_contents, meta, **options) |
There was a problem hiding this comment.
Do you mind changing payload_contents to contents to match create?
There was a problem hiding this comment.
It was long time ago) Currently I will prefer Golang integration over Ruby one
|
I would really like to see this feature implemented. |
4 participants
No description provided.