Fix default retry policy for certificate verification errors and bad request headers #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manicminer
approved these changes
May 9, 2024
manicminer
added a commit
that referenced
this pull request
May 9, 2024
Changelog for #210, release v0.7.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 started returning
*tls.CertificateVerificationErrorinstead ofx509.UnknownAuthorityErrorfor the tested certificate problem. The new error type check doesn't compile in old versions of Go because the type didn't exist yet, so this PR puts the old and new type checks in separate files with appropriate build tags. Fixes #176This also updates the default policy to disable retry after a "bad (outgoing) header" error from net/http.