Skip to content

Conversation

larsmaes
Copy link

@larsmaes larsmaes commented Nov 6, 2022

Fixes #33
Replaces #222

This is my first PR so please feel free to discus

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 6, 2022

CLA assistant check
All committers have signed the CLA.

@larsmaes
Copy link
Author

larsmaes commented Nov 8, 2022

I have used my own azure storage acccount for testing. I think it would be better to use a hashicorp provided storage account. Is there anyone in here that can deliver it?

@brentmannering
Copy link

@crw would you be able to nudge the Azure Provider team again please?
Support for blob storage has been requested for a number of years, with a number of people submitting PR's, this PR is just the most recent. It would be great to get this in so other tools like terraform can be enhanced and benefit from it.

@manicminer
Copy link

@larsmaes Thanks for opening this PR, apologies for the delay in reviewing. Whilst this is a feature we would be happy to add, unfortunately this PR is using the github.com/Azure/azure-sdk-for-go SDK, which we do not wish to use for a number of reasons. At this time, the supported SDK for Azure Storage can be found at https://github.com/jackofallops/giovanni - the implementation is much simpler and leans on our in-house Azure SDK for authentication and transport.

As such, whilst we'd like to add this features, we wouldn't be able to merge this in its current form. I'll go ahead and close this PR since unfortunately switching the SDK would essentially require reworking the entire change, but we can certainly look at merging a PR that uses our supported SDK.

@manicminer manicminer closed this Sep 16, 2024
@zsd4yr
Copy link

zsd4yr commented Jan 14, 2025

Hey @manicminer thanks for the feedback here :)

Can you share some of the concerns you have with the official azure go sdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Azure Blob Storage Support

5 participants