TestGCSGetter_GetGenerationFile: use our test bucket #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Mar 31, 2021
| t.Fatalf("err: %s", err) | ||
| } | ||
| if string(content) != "a" { | ||
| if string(content) != "a\n" { |
There was a problem hiding this comment.
Is there a reason we're adding the newlines to the test data?
There was a problem hiding this comment.
Nope, I created the file using echo a > file.txt and it added a \n, and I just felt like this was an okay change.
There was a problem hiding this comment.
That's fair. Trailing newline seems like a good practice - I just didn't know if there's anything more to it 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #310, @ScottSuarez proposed we put the GCP generational content in our bucket so that test things are in one place.
This PR uses our bucket.