Task1 home work #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakhmutov
force-pushed
the
task1-home-work
branch
from
00145a5 to
28195ed
Compare
dmakhmutov
force-pushed
the
task1-home-work
branch
from
28195ed to
8d85f42
Compare
spajic
approved these changes
Aug 2, 2019
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Очень хорошая работа, спасибо!
| @@ -0,0 +1,14 @@ | |||
| # frozen_string_literal: true | |||
| user_sessions = sessions.select { |session| session['user_id'] == user['id'] } | ||
| ``` | ||
|
|
||
| Решил данную проблему сразу сгруппировав сессию по user_id |
| В результате проделанной оптимизации наконец удалось обработать файл с данными. | ||
| Удалось улучшить метрику системы с бесконечно долго выполнения до 33 секунд | ||
|
|
||
| Было весело :) |
| @@ -0,0 +1,15 @@ | |||
| # brew install rbspy | |||
Collaborator
There was a problem hiding this comment.
👍 Плюсик за отдельные файлы для удобства работы
| File.delete(result_file_path) if File.exist?(result_file_path) | ||
| end | ||
|
|
||
| describe "#work" do |
dmakhmutov
force-pushed
the
task1-home-work
branch
from
c41373b to
8d85f42
Compare
stashevgenij
added a commit
to stashevgenij/rails-optimization-task1
that referenced
this pull request
Jun 23, 2022
hayah
pushed a commit
to hayah/rails-optimization-task1
that referenced
this pull request
Mar 5, 2023
araslanov-e
added a commit
to araslanov-e/rails-optimization-task1
that referenced
this pull request
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.