Allow sharing of JmDNS among multiple HomekitServer instances #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for niceness when having multiple bridges in a single process
Member
Author
|
extra bonus: in OpenHAB, we'll be able to use the JmDNS that ESH already manages |
timcharper
reviewed
Feb 18, 2019
| <groupId>javax.jmdns</groupId> | ||
| <groupId>org.jmdns</groupId> | ||
| <artifactId>jmdns</artifactId> | ||
| <version>3.4.1</version> |
Contributor
There was a problem hiding this comment.
hmm... breaking change to bump a minor version of a dependency? May need to wait for 1.2.0 release?
There was a problem hiding this comment.
Why is changing the maven organization from the abandoned name to the maintained name a breaking change (the implemented API did not change in a breaking way)?
yfre
pushed a commit
to yfre/HAP-Java
that referenced
this pull request
Dec 8, 2020
Signed-off-by: Eugen Freiter <[email protected]>
Member
Author
|
Superseded by #122 |
ccutrer
added a commit
that referenced
this pull request
Dec 11, 2020
port of #68 PR on jmDNS to latest code base
J-N-K
pushed a commit
to J-N-K/HAP-Java
that referenced
this pull request
Dec 28, 2020
* fix HAP subscription process * increase java version for travis * update fmt-maven-plugin to latest version * another fix for travis build. switch to openjdk * switch to openjdk8 * fix thermostat for io13. make temprature unit changeable * switch to openjdk * add subscribe/unsubscribe * fix the names of the garage door characteristics * switch to openjdk * hap-java#93 Fix discoverability & pairing with ios13 (hap-java#95) Switch discoverable to false once client is authenticated * Fixed package (hap-java#98) * add carbon dioxide sensor (hap-java#82) * increase java version * switch to openjdk8 * major refactoring to support optional attributes * add name, active and fault interfaces * make service characteristics complete * update CHANGES.md and README.md * Apply J-N-K patches for Openhab. update dependencies to be aligned with OH * fix some typos in the characteristics descriptions * fix for javadoc bug * fix potential NPE. adapt log level Signed-off-by: Eugen Freiter <[email protected]> * fix typo and add some logging Signed-off-by: Eugen Freiter <[email protected]> * Add Doorbell, Microphone, Slat, Speaker, StatelessProgrammableSwitch accessories Signed-off-by: Eugen Freiter <[email protected]> * update readme Signed-off-by: Eugen Freiter <[email protected]> * add air purifier and air quality Signed-off-by: Eugen Freiter <[email protected]> * reduce log leve. align more with OH guidance on logging Signed-off-by: Eugen Freiter <[email protected]> * add service label service and hap protocol version service. fix Mute characteristic Signed-off-by: Eugen Freiter <[email protected]> * fix the Id for TargetHorizontalTiltAngleCharacteristic Signed-off-by: Eugen Freiter <[email protected]> * add Faucet and HeaterCooler Signed-off-by: Eugen Freiter <[email protected]> * add humidifier dehumidifier accessory Signed-off-by: Eugen Freiter <[email protected]> * add irrigation system, clean up javadocs Signed-off-by: Eugen Freiter <[email protected]> * remove reference to spec Signed-off-by: Eugen Freiter <[email protected]> * add support for custom min/max values for temperatures Signed-off-by: Eugen Freiter <[email protected]> * fix typos. add support for custom min/max values for threshold temperatures Signed-off-by: Eugen Freiter <[email protected]> * add constants for default min/max values Signed-off-by: Eugen Freiter <[email protected]> * put debugData back Signed-off-by: Eugen Freiter <[email protected]> * fix the typo in CarbonDioxideSensorService * add support for valid-values (for enum characteristics) * CHANGES update * [hap-java#119] added support for valid values for target HumidifierDehumidifierState * [hap-java#119] added support for valid values for target HumidifierDehumidifierState * [hap-java#119] added support for valid values for target HumidifierDehumidifierState * [hap-java#119] added support for valid values for target HumidifierDehumidifierState * add support for qr code Signed-off-by: Eugen Freiter <[email protected]> * add default implementation for setup Id Signed-off-by: Eugen Freiter <[email protected]> * add support for linked services Some services require linked services to work, for example, the Television service which requires each input to be a linked service. With this change, support to link services is added, though it's not used in any existing service, as they don't need linking. This change also centralizes the generation of interface ids. They are now only generated in the registry. We were previously also generating them in the accessory controller, relying on an identical processing sequence. * port of hap-java#68 PR on jmDNS to latest code base Signed-off-by: Eugen Freiter <[email protected]> * incorporate review feedback Signed-off-by: Eugen Freiter <[email protected]> * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) * [hap-java#124](hap-java#124 * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) typo in JavaDoc * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) JavaDoc error fixed * Add support for FilterMaintenanceAccessory [hap-java#124](hap-java#124) JavaDoc error fixed * add linked service API Signed-off-by: Eugen Freiter <[email protected]> * expose addLinkedService at Service interface Signed-off-by: Eugen Freiter <[email protected]> * prepare release Signed-off-by: Eugen Freiter <[email protected]> Co-authored-by: Cody Cutrer <[email protected]> Co-authored-by: Eugen Freiter <[email protected]> Co-authored-by: sobeos <[email protected]> Co-authored-by: Eugen Freiter <[email protected]> Co-authored-by: Martin Hanes <[email protected]> Co-authored-by: Jiří Václavovič <[email protected]> Co-authored-by: Gert-Jan van der Heiden <[email protected]> Co-authored-by: Dennis Frommknecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for niceness when having multiple bridges in a single process