Some streamlining #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* events is actually called ev * there is no bonjour field
HAP spec allows shortening UUIDs if they're well known Apple ones doing this drastically reduces response sizes
andylintner
reviewed
Feb 12, 2019
Collaborator
andylintner
left a comment
andylintner
left a comment
There was a problem hiding this comment.
We probably want to allow both long and short ids - there is support in the spec for custom types. Can you change this to use the long id if it doesn't match the expression?
Member
Author
|
It already does. Non-Apple IDs won't match the regex, so will not have any replacements done, returning the original string (I tested this). |
Collaborator
|
Huh, just read the javadoc on replaceAll - you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some minor optimizations to reduce the /accessories response size