-
Notifications
You must be signed in to change notification settings - Fork 452
Add boo button pad #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boo button pad #629
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
i'd recommend adding an image of the top part of the case |
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You currently have too much switches, the max for a macropad is 16x! Sorry! Plus 24 M3x16mm screws doesn't sound right. Also you are missing a plate/top case picture!
|
@cheyao I can get the picture, but I was told by one of the organizers of this that I was allowed to have more if I payed for it. |
|
Hm then you are prob fine |
|
except for the missing picture it LGTM, my approved PR is #634 |
|
@Kaympe20 can you please ask @booboojp to add the files requested and address the points asked by the community reviewers? you can add them as a contributer to the fork so they can make edits |
|
They are banned permanently from HC. |
|
okay no hackpad for them |
This is @booboojp's submission as he was unable to properly clone this repo. All files are directly from him.
Check off the following to let the reviewers know you've done everything: