-
Notifications
You must be signed in to change notification settings - Fork 451
add atlaspad (fixed broken step file) #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I approve this submission. My approved PR: 507 |
dk, i redid the PR when i noticed an issue with my submission and then it wouldn’t work anymore. probably that caused it somehow tho |
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W this looks cool!
Though I think you should decrease the 22uF cap's value, since USBs only allow max 10uF. You also need to add a pic of the schematic to the readme!
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm #4
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hihi, can you remove the libraries and the unzipped gerbers? it takes up a lot of space on the repo
|
@Volkov997 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi yes, i removed all the unzipped gerbers and i zipped the libraries down to abt 10%. |
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! this is an awesome hackpad! Fill out this form
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[Y] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[Y] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[Y] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[Y] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[Y] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[Y] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!