N0PAD #541
N0PAD #541
Conversation
My finished macropad (yay) ├── CAD │ ├── N0PAD.stl/.step │ └── plate-2024-10-06T07_43_05.166Z.dxf ├── firmware │ └── KMK │ └──main.py └── PCB ├── N0PAD.pro └── N0PAD.sch
added gerbers.zip file for gerber time
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
M0HID
left a comment
M0HID
left a comment
There was a problem hiding this comment.
Hi! Great work on this but can you remove all the unnecessary files please? e.g. the backups and all the examples you have. Thanks!
|
I removed some files, that good? |
return-misaPuding
left a comment
return-misaPuding
left a comment
There was a problem hiding this comment.
PR #634 , LGTM! i´ll let you cook
M0HID
left a comment
M0HID
left a comment
There was a problem hiding this comment.
Theres still wayy too many files in this pr! Could you delete all the unused files and libraries (you dont need the whole MX_V2 library, just the footprints you've used!). Once you do that I can approve this!
|
I really still don't understand what specifically you want me to delete, but sure, I tried |
Taran-the-Idiot
left a comment
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
hihi, can you please delete the assets folder in your pcb folder
Also can you move you gerbers and stls to a separate folder labeled production. you can see it in the guide https://hackpad.hackclub.com/submitting
|
@spacevini8 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
why do I need to delete the assets folder? I've been at this for like, more than a year, but sure, I'll delete the assets folder. |
|
check #hackpad-announcements on slack. tldr reviews are finally happening. also no libraries in your repo |
|
there, I did what you asked, anything else? |
Taran-the-Idiot
left a comment
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
okay looks good, approved
|
yippie!!! |
5 participants
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[Y] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[Y] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[Y] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[Y] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[Y] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[Y] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!