-
Notifications
You must be signed in to change notification settings - Fork 452
ChessPad #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChessPad #530
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You don't need the .gbr or backup files. Additional make sure your file structure is like this |
|
@GaoYeGithub I've deleted the proper files, hope it's all set now |
|
could you maybe add images to the readme? |
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM #4, just please add pics of schematic and case to readme!
|
Screenshots have been added (I just didn't know how to add them to a Readme before lol) |
return-misaPuding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (my PR is #634 ) - interesting key layout, your WASD is quite displaced, but you can quickly adjust that with the firmware once you receive your hackpad
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the xiao library please. otherwise lgtm
…Series Library directory I was asked to when someone reviewed it, that's all.
|
@AyoubChafiq is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
@Overlord-Runt I deleted it, hopefully all is well now. |
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. approved!
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
Yup - [] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
Yup - [] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
Yup - [] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
No clue - [] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
Yup - [] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
Yup - [] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
Probably - Full render including all the parts
Yup - A few sentences about the inspiration and challenges
Yup - BOM
Yup - Photos of the Schematic, PCB, and case
*Pretend the boxes are checked
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!