Skip to content

Conversation

@ethanJPope
Copy link

@ethanJPope ethanJPope commented Oct 22, 2024

MyReady to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

If you're unsure about the format, make sure to check out the Orpheuspad example and follow the format there.

If this PR isn't a submission, that's okay too! If there's anything about this PR template that seems confusing, let me know in #hackpad on the slack!

I accidentally closed my pull request
This is a submission for Ethan Pope

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:04am

@Hyatt-B
Copy link

Hyatt-B commented Oct 22, 2024

CAD looks good as long as your USB-c cable's metal part is able to fit in there. @hyatt B.

@ethanJPope
Copy link
Author

ethanJPope commented Oct 22, 2024

It does i tested with a test print earlier this last weekend

@Hyatt-B
Copy link

Hyatt-B commented Oct 22, 2024

okay. This CAD looks good to me then. @hyatt B.

Copy link
Collaborator

@M0HID M0HID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but could you add your source KiCad files to the pcb folder please? I'll be able to review them once you've done that.

@ethanJPope
Copy link
Author

ethanJPope commented Oct 26, 2024

it is the keyboard.zip file

@M0HID
Copy link
Collaborator

M0HID commented Oct 26, 2024

No I need the source files e.g. *.kicad_pro or *.kicad_sch or *.kicad_pcb

@ethanJPope
Copy link
Author

does that work

@ethanJPope
Copy link
Author

can someone check mine

@scooterthedev
Copy link
Member

can someone check mine

Hey @ethanJPope! I just reviewed your PR and everything looks good besides for one small issue. In the root folder, please add a folder called production, and within the folder please put in your uf2 file and your gerber.zip. Along with that, please add a sub-folder within production called cad, and put all your stls in there. After that, please let me know, so I can give my approval.

If your a little confused here is a breakdown on how your folder structure should look like:

Root Macro Pad ->
README.md
cad -> your step file with everything put together to demonstrate how it will look
pcb -> your gerber.zip, your schematic and your kicad files
firmware -> your code for the macro pad
production -> your uf2 file, and gerber.zip
cad -> your stl files that are going to be printed.

@scooterthedev
Copy link
Member

Amazing Job @ethanJPope! It looks amazing! I approve #256!

PS: My slack handle is Scooter Y

@ItIsIEli
Copy link
Contributor

ItIsIEli commented Oct 28, 2024

Fantastimazing Job @ethanJPope! It looks muy bien! I approve #137!
My slack handle is Eli

Copy link
Collaborator

@M0HID M0HID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again its missing the KiCad source files!

I need the schematic (Keyboard.kicad_sch)
And the PCB (Keyboard.kicad_pcb)

Please add them to your PR so I can review!

@ItIsIEli
Copy link
Contributor

ItIsIEli commented Oct 29, 2024 via email

@ethanJPope
Copy link
Author

I added the source files

Copy link
Collaborator

@M0HID M0HID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! You can order your Hackpad here!!

@M0HID M0HID merged commit f466d0d into hackclub:main Oct 29, 2024
@M0HID M0HID mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants