-
Notifications
You must be signed in to change notification settings - Fork 452
Ethan hackpad #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethan hackpad #254
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CAD looks good as long as your USB-c cable's metal part is able to fit in there. @hyatt B. |
|
It does i tested with a test print earlier this last weekend |
|
okay. This CAD looks good to me then. @hyatt B. |
M0HID
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far but could you add your source KiCad files to the pcb folder please? I'll be able to review them once you've done that.
|
it is the keyboard.zip file |
|
No I need the source files e.g. *.kicad_pro or *.kicad_sch or *.kicad_pcb |
|
does that work |
|
can someone check mine |
Hey @ethanJPope! I just reviewed your PR and everything looks good besides for one small issue. In the root folder, please add a folder called production, and within the folder please put in your uf2 file and your gerber.zip. Along with that, please add a sub-folder within production called cad, and put all your stls in there. After that, please let me know, so I can give my approval. If your a little confused here is a breakdown on how your folder structure should look like: Root Macro Pad -> |
|
Amazing Job @ethanJPope! It looks amazing! I approve #256! PS: My slack handle is Scooter Y |
|
Fantastimazing Job @ethanJPope! It looks muy bien! I approve #137! |
M0HID
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again its missing the KiCad source files!
I need the schematic (Keyboard.kicad_sch)
And the PCB (Keyboard.kicad_pcb)
Please add them to your PR so I can review!
|
ok!
…On Mon, Oct 28, 2024 at 4:37 PM M0HID ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Again its missing the KiCad source files!
I need the schematic (Keyboard.kicad_sch)
And the PCB (Keyboard.kicad_pcb)
Please add them to your PR so I can review!
—
Reply to this email directly, view it on GitHub
<#254 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJNQNNJ2C3WVS5L2J5KLRQ3Z524BDAVCNFSM6AAAAABQNGUTDKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBQGQZTMNZXGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
I am The-E
|
|
I added the source files |
M0HID
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! You can order your Hackpad here!!
MyReady to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
If you're unsure about the format, make sure to check out the Orpheuspad example and follow the format there.
If this PR isn't a submission, that's okay too! If there's anything about this PR template that seems confusing, let me know in #hackpad on the slack!
I accidentally closed my pull request
This is a submission for Ethan Pope