-
Notifications
You must be signed in to change notification settings - Fork 452
Coder Kid's Hackpad #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coder Kid's Hackpad #134
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello! Please rename the directories to the required names, for example And I don't see a case in your project The PCB is ok. No big problems. The firmware looks copy-pasted, you still got example username and yourwebsite.com there? I think you should modify it to be a bit less template-y. Anyways I'll approve after you make some changes. |
|
Hi , i renamed the name from 'MY PCB' to 'PCB' , Also I can't find any spaces in any files name Also i didn't understood wdym by " you still got example username and yourwebsite.com there? I think you should modify it to be a bit less template-y. " |
|
And yea , I'm really struggling with the case .. i asked from alex to give me a week more .. and he approved me , so can you pls wait wait for some more time? and pls send you're slack username so i can inform you whether my pr is fully done or not |
|
You see here: Here you see, there are spaces in the file names, but just leave it so. It is just a tiny nuisance. My slack is @cyao feel free to ping me when you are dome :D |
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh hate to say it but you are using the wrong footprint for the xiao. See in your pcb vcc is in the bottom right

But it should be in the top right

So your row 2 is currently connected to 5V
You should also change the xiao schematic to a more accurate one. (Download it from the OPL lib)
In the CAD your USB hole isn't a hole

And what are these holes for? You will have a PCB in the middle without holes so you can't put screws in them

|
Did all the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the 7)
"All the components are through-hole "
I dont think so its needed
: )
Done |
souptik-samanta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve #85
|
I approve #181 |
jpt1729
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM #4 |
|
I approve #92 |
|
damn y'all 😭 Approved, you can get it here https://forms.hackclub.com/hackpad have fun and thanks everyone for reviewing! |


Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
If you're unsure about the format, make sure to check out the Orpheuspad example and follow the format there.
If this PR isn't a submission, that's okay too! If there's anything about this PR template that seems confusing, let me know in #hackpad on the slack!