Make gf on res:// paths open the correct file #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After using this for a while, I think it's pretty good. I occasionally |
|
@habamax Is there anything blocking merging this PR? |
Fix gf on `extends "res://cars/car_base.gd"` opens
`"res://cars/car_base.gd"` instead of `C:/project/cars/car_base.gd`.
The includeexpr isn't sufficient to open these files because vim sees
res:// as a valid filepath and fails to invoke it includeexpr. Possibly
includeexpr is unnecessary; I don't entirely understand what it's for.
Use a similar method to netrw and use BufReadCmd to capture attempts to
edit res:// files and resolve to the intended file. During this resolve,
we're already editing the res:// path, so the old
findfile("project.godot", ".;") returns a nonsense path (vim/vim#11060)
and we need to try harder.
Test
* gf on a extends line
* edit res://file without ever opening a godot project and it still
opens res://file.
I fixed this issue by making the autocmd nested. Seems like it's consistently loading the syntax of destination files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I haven't tested this enough, butI saw your comment on my related vim question, so I thought I'd post so you can see and it might be awhile before I work on it again.Fix gf on
extends "res://cars/car_base.gd"opens"res://cars/car_base.gd"instead ofC:/project/cars/car_base.gd.The includeexpr isn't sufficient to open these files because vim sees res:// as a valid filepath and fails to invoke it includeexpr. Possibly includeexpr is unnecessary; I don't entirely understand what it's for.
Use a similar method to netrw and use BufReadCmd to capture attempts to edit res:// files and resolve to the intended file. During this resolve, we're already editing the res:// path, so the old
findfile("project.godot", ".;") returns a nonsense path (vim/vim#11060) and we need to try harder.
Test