glib: Fix bug in main context channel test that caused it to deadlock #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With edition 2021 the closures are only borrowing what they have to, so here in this case it didn't actually borrow the helper as it was not actually used inside the closure. With that, it was not dropped when the main context channel was dropped and the main loop was never quit.
bilelmoussaoui
approved these changes
Nov 1, 2021
|
Reported this also here: rust-lang/rust#90465 . Just in case this was not an intentional change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With edition 2021 the closures are only borrowing what they have to, so
here in this case it didn't actually borrow the helper as it was not
actually used inside the closure. With that, it was not dropped when the
main context channel was dropped and the main loop was never quit.