Skip to content

Add support for async await #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bordunosp opened this issue Jun 24, 2021 · 8 comments · Fixed by #1231
Closed

Add support for async await #1205

bordunosp opened this issue Jun 24, 2021 · 8 comments · Fixed by #1231
Labels
kind/enhancement Improvements to existing feature.

Comments

@bordunosp
Copy link

are you planning to move to the "async-await" paradigm?
mb there is already some branch for tests?

@bordunosp bordunosp added the kind/enhancement Improvements to existing feature. label Jun 24, 2021
@glbrntt glbrntt changed the title swift 5.5 async await Add support for async await Jun 25, 2021
@glbrntt
Copy link
Collaborator

glbrntt commented Jun 25, 2021

Yes, we plan on adopting async await. We don't have anything for users to play around with yet though.

@bordunosp
Copy link
Author

swift-nio has already demo sources for support swift 5.5
https://github.com/apple/swift-nio/tree/main/Sources/NIOAsyncAwaitDemo

and around this vapor has branch https://github.com/vapor/vapor/tree/async-await

@glbrntt glbrntt linked a pull request Jul 28, 2021 that will close this issue
@glbrntt glbrntt reopened this Aug 10, 2021
@glbrntt
Copy link
Collaborator

glbrntt commented Sep 16, 2021

We now have an experimental release with initial support async/await https://github.com/grpc/grpc-swift/releases/tag/1.4.1-async-await.1

@Jerry-Carter
Copy link

Thank you for the 1.4.1-async-await branch. Curious what the roadmap is. Specifically, are there plans for a 1.5.0-async-await branch? Do you anticipate this being folded in before 2.0? Thanks.

@glbrntt
Copy link
Collaborator

glbrntt commented Nov 2, 2021

Thank you for the 1.4.1-async-await branch. Curious what the roadmap is. Specifically, are there plans for a 1.5.0-async-await branch?

Yes, we'll try to get that done soon.

Do you anticipate this being folded in before 2.0?

Yes. The rough plan is to expose an async/await API alongside the existing API in a 1.x release so folks can move over to it if/when they choose. The next major version would drop the old API and keep just the async/await API as close as feasibly possible (at least for generated clients and service providers) in order to make migration from 1.x to 2.x less painful.

With that in mind I'd like to leave this a little more time to let the current async/await APIs bake and also to improve test coverage. Feedback on APIs, usability and so on are always helpful so please let us know if you have any thoughts!

@glbrntt
Copy link
Collaborator

glbrntt commented Jun 14, 2022

Support for async await was added in the 1.8.0 release.

@glbrntt glbrntt closed this as completed Jun 14, 2022
@cristian064
Copy link

Support for async await was added in the 1.8.0 release.

Hi do you know where can I find the documentation about how to use async await on GRPC?

@glbrntt
Copy link
Collaborator

glbrntt commented Jul 14, 2022

This is probably the best place to start: https://github.com/grpc/grpc-swift/blob/main/docs/basic-tutorial.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants