-
Notifications
You must be signed in to change notification settings - Fork 683
feat: bump grpc-tools @mapbox/node-pre-gyp version #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note this would raise the minimum supported node version for this library to 18 itself is already EOL, but typically Linux-based operating systems only carry very, very old versions of Node, so it might be problematic in some cases. |
|
@murgatroid99 before I burn a bunch of time figuring out how to test this on Windows, could you confirm those are unexpected failures? I can't see much helpful in the logs, but I'm also not sure what to look out for 🤓 |
|
Don't worry about those. They're irrelevant. The grpc-tools build jobs are the relevant ones here. Also, can you bump the library's patch version? |
|
@murgatroid99 I don't think there's a later version? https://www.npmjs.com/package/@mapbox/node-pre-gyp only goes to I'd seen the |
|
The library maintainers seem to be unsure how they can solve their publishing woes from glancing through mapbox/node-pre-gyp#907 |
|
OH you meant the grpc-tools library version! Suddenly dawned on me while making coffee. Done. |
27191d7 to
51b8020
Compare
|
Anything else you need from me @murgatroid99? No worries if you're busy, I can nudge again in a few weeks. Wasn't sure what expectations to set. |
|
You're good, my attention has just been split. I'll be able to handle this soon. |
fixes: #2968