auth: Add support for Retryable interface #9102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retryable was added in google-auth-library 1.5.3 to make clear the situations that deserve a retry of the RPC. Bump to that version and swap away from the imprecise IOException heuristic. go/auth-correct-retry Fixes grpc#6808
auth/src/test/java/io/grpc/auth/GoogleAuthLibraryCallCredentialsTest.java
Show resolved
Hide resolved
auth/src/test/java/io/grpc/auth/GoogleAuthLibraryCallCredentialsTest.java
Show resolved
Hide resolved
auth/src/test/java/io/grpc/auth/GoogleAuthLibraryCallCredentialsTest.java
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java
Show resolved
Hide resolved
Contributor
sanjaypujare
left a comment
sanjaypujare
left a comment
There was a problem hiding this comment.
I left a comment about a missing test where the Exception is not a RetryableException (but an IOException or not even an IOException).
|
Passing by - Thanks for fixing! |
Member
Author
|
Reverted by #9118 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retryable was added in google-auth-library 1.5.3 to make clear the
situations that deserve a retry of the RPC. Bump to that version and
swap away from the imprecise IOException heuristic.
go/auth-correct-retry
Fixes #6808
CC @TimurSadykov