Document that xds uses grpc-netty-shaded #7877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sanjaypujare
reviewed
Feb 8, 2021
SECURITY.md
Outdated
| BoringSSL. It includes pre-built libraries for 64 bit Windows, OS X, and 64 bit | ||
| Linux. For 32 bit Windows, Conscrypt is an option. For all other platforms, Java | ||
| 9+ is required. | ||
| We recommend most users use [grpc-netty-shaded](#tls-with-grpc-netty-shaded). |
Contributor
There was a problem hiding this comment.
How about rewording this to say something like "users of xDS management protocol" which is what the original issue was?
Contributor
There was a problem hiding this comment.
Waiting to address the comment so we can go ahead and merge this....
ejona86
reviewed
Feb 13, 2021
Contributor
|
@lepistone could you address the comments so we can merge the PR? Thanks |
lepistone
force-pushed
the
document-netty-shaded-xds
branch
from
bfa4e7a to
2461167
Compare
Contributor
Author
|
I removed the additional paragraph so I am now only adding a paragraph. This should address both comments. Sorry it took so long and thanks for reviewing! |
sanjaypujare
added
the
kokoro:run
ejona86
approved these changes
May 11, 2021
ejona86
added
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clarity, also extract grpc-netty-shaded to a separate paragraph.
Closes: #7869.