api: make Subchannel.requestConnection() thread-safe. #5736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is called by pick-first LoadBalancer from the data-path, thus has to be thread-safe.
zhangkun83
added
the
TODO:backport
zhangkun83
added a commit
to zhangkun83/grpc-java
that referenced
this pull request
May 15, 2019
…ection(). Contrary to grpc#5736, we will still keep the sync-context requirement of requestConnection(), because it prevents API fragmentation. PickFirstLoadBalancer is the only known violator. We will fix it on master, but we don't want to make that change on 1.21.x because the release is soon. We simply remove the warning in this release so that users won't be annoyed. This supersedes grpc#5736
Contributor
Author
|
Closing in favor of #5738 |
zhangkun83
added a commit
that referenced
this pull request
May 15, 2019
…ection(). (#5738) Contrary to #5736, we will still keep the sync-context requirement of requestConnection(), because it prevents API fragmentation. PickFirstLoadBalancer is the only known violator. We will fix it on master, but we don't want to make that change on 1.21.x because the release is soon. We simply remove the warning in this release so that users won't be annoyed. This supersedes #5736
zhangkun83
removed
the
TODO:backport
zhangkun83
added a commit
to zhangkun83/grpc-java
that referenced
this pull request
May 16, 2019
…ection(). (grpc#5738) Contrary to grpc#5736, we will still keep the sync-context requirement of requestConnection(), because it prevents API fragmentation. PickFirstLoadBalancer is the only known violator. We will fix it on master, but we don't want to make that change on 1.21.x because the release is soon. We simply remove the warning in this release so that users won't be annoyed. This supersedes grpc#5736
zhangkun83
added a commit
that referenced
this pull request
May 16, 2019
…ection(). (#5738) (#5752) Contrary to #5736, we will still keep the sync-context requirement of requestConnection(), because it prevents API fragmentation. PickFirstLoadBalancer is the only known violator. We will fix it on master, but we don't want to make that change on 1.21.x because the release is soon. We simply remove the warning in this release so that users won't be annoyed. This supersedes #5736
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is called by pick-first LoadBalancer from the data-path, thus has
to be thread-safe.
This is a revision to #5718 thus has to be back-ported to 1.21.x as well.