Skip to content

Conversation

@shivaspeaks
Copy link
Member

@shivaspeaks shivaspeaks commented Jul 16, 2025

envoyproxy/envoy: Sync protos to the latest imported version envoyproxy/envoy@1128a52 (commit 2025-06-18).

Should be a noop, just a routine xDS proto update.

@shivaspeaks shivaspeaks requested a review from ejona86 July 16, 2025 16:24
@shivaspeaks
Copy link
Member Author

Note: I added cidr.proto that's in xds and address.proto myself. import.sh didn't add it and then it was failing for files not found.

@ejona86
Copy link
Member

ejona86 commented Jul 16, 2025

Note: I added cidr.proto that's in xds and address.proto myself. import.sh didn't add it and then it was failing for files not found.

import.sh has a list of files to import.

@shivaspeaks
Copy link
Member Author

shivaspeaks commented Jul 16, 2025

Oh we have a different import.sh for xds protos.
https://github.com/grpc/grpc-java/blob/master/xds/third_party/xds/import.sh#L20

So we need to update import new version from xds OSS in a same way? Is there any rulebook or some process to follow? Maybe we should be doing both imports in separate PRs.

@ejona86
Copy link
Member

ejona86 commented Jul 16, 2025

It wouldn't be weird to upgrade the "xds" and "envoy" protos at the same time. You might need to upgrade even more than that at once to get everything working together.

@shivaspeaks
Copy link
Member Author

Oh I didn't see your comment here, and I was already working and created a PR for xds proto import: #12225

@shivaspeaks shivaspeaks marked this pull request as ready for review July 28, 2025 08:46
@shivaspeaks shivaspeaks merged commit c3ef1ab into grpc:master Jul 28, 2025
16 checks passed
@shivaspeaks shivaspeaks deleted the envoy_proto_sync branch July 28, 2025 15:26
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2025
@shivaspeaks shivaspeaks changed the title xds: Envoy proto sync to xds: Envoy proto sync to 2025-06-18 Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants