Skip to content

servlet: set description for CANCELLED status #11927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivaspeaks merged 2 commits into from
Mar 12, 2025
Merged

servlet: set description for CANCELLED status #11927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9749042
servlet: description for CANCELLED status
panchenko Feb 27, 2025
d0fe1e4
update message
panchenko Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,9 @@ public void cancel(Status status) {
}
transportState.runOnTransportThread(() -> transportState.transportReportStatus(status));
// There is no way to RST_STREAM with CANCEL code, so write trailers instead
close(Status.CANCELLED.withCause(status.asRuntimeException()), new Metadata());
close(Status.CANCELLED.withDescription("Servlet stream cancelled")
.withCause(status.asRuntimeException()),
new Metadata());
CountDownLatch countDownLatch = new CountDownLatch(1);
transportState.runOnTransportThread(() -> {
asyncCtx.complete();
Expand Down