xds:Move creating the retry timer in handleRpcStreamClosed to as late as possible and call close() #11776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible and call `close` so that the `call` is cancelled. Also add some debug logging.
ejona86
reviewed
Dec 26, 2024
… message to reference `Stream` instead of `transport`
ejona86
approved these changes
Jan 6, 2025
larry-safran
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
close()instead of explicitly settingclosed = trueand callingcleanup()since that will also terminate the underlying ClientCall.Also add some debug logging.