stats/otel: Add up down counter for A94 #8581
Conversation
mbissa
force-pushed
the
a94-subchannel-metrics
branch
from
20f43a0 to
e4d9b0e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8581 +/- ##
==========================================
- Coverage 81.64% 80.48% -1.17%
==========================================
Files 413 413
Lines 40621 40933 +312
==========================================
- Hits 33167 32946 -221
- Misses 5991 6286 +295
- Partials 1463 1701 +238
🚀 New features to boost your workflow:
|
|
Please follow the instructions mentioned here and update the PR description: https://github.com/grpc/grpc-go/blob/master/CONTRIBUTING.md#pr-descriptions Specifically the following: |
| recorder.RecordInt64Count(h, incr, labels...) | ||
| } | ||
|
|
||
| // Int64UpDownCountHandle is a typed handle for an int up-down counter metric. |
There was a problem hiding this comment.
I understand this docstring is very similar to the existing one for Int64CountHandle. But I'm curious as to what the "typed handle" means here.
| } | ||
| ret, err := meter.Int64UpDownCounter(string(metricName), options...) | ||
| if err != nil { | ||
| logger.Errorf("failed to register metric \"%v\", will not record: %v", metricName, err) |
There was a problem hiding this comment.
Nit: Log statements should follow capitalization rules for regular sentences, and not the ones that apply to error strings. See: go/go-style/decisions#error-strings
stats/otel: Part 1 for A94
Adds up down counter boiler plate code
RELEASE NOTES: none