-
Couldn't load subscription status.
- Fork 4.6k
balancer/wrr: prefer calling Equal() method of time.Time #7529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7529 +/- ##
==========================================
- Coverage 82.07% 81.83% -0.25%
==========================================
Files 360 360
Lines 27533 27508 -25
==========================================
- Hits 22599 22510 -89
- Misses 3759 3799 +40
- Partials 1175 1199 +24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more occurrences:
easwars@minetop: grpc-go$ grep -r "==.*time.Time{}" *
balancer/weightedroundrobin/balancer.go: if w.nonEmptySince == (time.Time{}) {
balancer/weightedroundrobin/balancer.go: if w.lastUpdated == (time.Time{}) {
balancer/weightedroundrobin/balancer.go: if blackoutPeriod != 0 && (w.nonEmptySince == (time.Time{}) || now.Sub(w.nonEmptySince) < blackoutPeriod) {
test/config_selector_test.go: if wantDeadline == (time.Time{}) {
Prefer calling Equal() method of time.Time over direct comparision.
RELEASE NOTES: none