Skip to content

Conversation

@dfawley
Copy link
Member

@dfawley dfawley commented Aug 16, 2024

This could actually lead to a panic if the auth type reports "tls" but the AuthInfo is not a credentials.TLSInfo. There is no evidence this is happening and has been this way for a long time.

RELEASE NOTES: none

@dfawley dfawley added this to the 1.66 Release milestone Aug 16, 2024
@dfawley dfawley requested review from arvindbr8 and ejona86 August 16, 2024 18:42
@codecov
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (b45fc41) to head (b13934e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7522      +/-   ##
==========================================
- Coverage   82.07%   81.90%   -0.18%     
==========================================
  Files         360      360              
  Lines       27533    27531       -2     
==========================================
- Hits        22599    22550      -49     
- Misses       3759     3788      +29     
- Partials     1175     1193      +18     
Files Coverage Δ
internal/xds/rbac/rbac_engine.go 82.81% <100.00%> (-0.27%) ⬇️

... and 16 files with indirect coverage changes

Copy link
Contributor

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have my authoritative LGTM

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Aug 16, 2024
@dfawley dfawley merged commit f8d98a4 into grpc:master Aug 16, 2024
1 check passed
@dfawley dfawley deleted the auth branch August 16, 2024 22:03
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants