Skip to content

Conversation

@KarthikReddyPuli
Copy link
Contributor

@KarthikReddyPuli KarthikReddyPuli commented Jun 30, 2024

ValueFromIncomingContext is an API available in metadata package which can be used to fetch single key from grpc metadata with lower memory footprint and cpu time. This PR stabilises the API after which this can be used safely

Fixes: #7298

RELEASE NOTES:

  • metadata: stabilize ValueFromIncomingContext

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2024

CLA Signed

  • ✅login: KarthikReddyPuli / (f8a2089)

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (f199062) to head (f8a2089).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7368      +/-   ##
==========================================
- Coverage   81.64%   81.47%   -0.17%     
==========================================
  Files         348      348              
  Lines       26755    26755              
==========================================
- Hits        21844    21799      -45     
- Misses       3744     3769      +25     
- Partials     1167     1187      +20     
Files Coverage Δ
metadata/metadata.go 89.09% <ø> (ø)

... and 23 files with indirect coverage changes

@KarthikReddyPuli KarthikReddyPuli changed the title Metadata: Remove stabilising an API in metadata package Metadata: Stabilising an API in metadata package Jun 30, 2024
@arjan-bal arjan-bal requested a review from dfawley July 1, 2024 08:39
@arjan-bal arjan-bal added this to the 1.66 Release milestone Jul 1, 2024
@dfawley dfawley changed the title Metadata: Stabilising an API in metadata package metadata: stabilize ValueFromIncomingContext Jul 1, 2024
@dfawley dfawley added the Type: Feature New features or improvements in behavior label Jul 1, 2024
@easwars easwars merged commit d382d84 into grpc:master Jul 2, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experimental API related to metadata

5 participants