Skip to content

Conversation

@townba
Copy link
Contributor

@townba townba commented May 2, 2024

… to limit calls to pretty.ToJSON

RELEASE NOTES: None

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea of the impact of this more isolated change yet?

@dfawley dfawley added the Type: Performance Performance improvements (CPU, network, memory, etc) label May 2, 2024
@dfawley dfawley added this to the 1.64 Release milestone May 2, 2024
@townba
Copy link
Contributor Author

townba commented May 2, 2024

Any idea of the impact of this more isolated change yet?

From what I saw, it was about as good as the larger-scale change, though I only had it in two VMs over the weekend.

@dfawley dfawley changed the title xds/internal: Replace calls to Debugf with V(2) checks and Infof xds/internal: Replace calls to Debugf with V(2) checks and Infof May 2, 2024
@dfawley dfawley merged commit c7c8aa8 into grpc:master May 2, 2024
1 check passed
@townba townba deleted the townba-debugf branch May 9, 2024 19:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Performance Performance improvements (CPU, network, memory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants