vet: run staticcheck for all sub modules #7155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified the behavior of |
dfawley
reviewed
Apr 22, 2024
| }` | ||
|
|
||
| cleanup, err := createTmpConfigInFileSystem(configJSON) | ||
| cleanup, _ := createTmpConfigInFileSystem(configJSON) |
scripts/vet.sh
Outdated
Comment on lines
46
to
47
| # - Do not import x/net/context. | ||
| not git grep -l 'x/net/context' -- "*.go" | ||
| not git grep --quiet -l 'x/net/context' -- "*.go" |
There was a problem hiding this comment.
Let's just remove this? It's a symlink now, and there's no reason we would be using it anymore, anyway.
There was a problem hiding this comment.
Sure. I'm not so sure about it. Removing it from vet.
There was a problem hiding this comment.
Did I say "symlink"? I meant "type alias" O_O
| pushd ${MOD_DIR} | ||
| # - Collection of static analysis checks | ||
| SC_OUT="$(mktemp)" | ||
| staticcheck -go 1.19 -checks 'all' ./... >"${SC_OUT}" || true |
There was a problem hiding this comment.
Maybe just move this into the previous for loop instead of adding another one?
scripts/vet.sh
Outdated
| # Error for anything other than checks that need exclusions. | ||
| grep -v "(ST1000)" "${SC_OUT}" | grep -v "(SA1019)" | grep -v "(ST1003)" | not grep -v "(ST1019)\|\(other import of\)" | ||
| # Error for anything other than checks that need exclusions. | ||
| (grep -v "(ST1000)" "${SC_OUT}" || : )| (grep -v "(SA1019)" || :) | (grep -v "(ST1003)" || :) | (grep -v "(ST1019)\|\(other import of\)" || :) | not grep -v "(SA4000)" |
There was a problem hiding this comment.
Can we define a function for this grep || : pattern instead?
security/advancedtls/crl.go
Outdated
| } | ||
| der := cryptobyte.String(crlBytes) | ||
| var issuer cryptobyte.String | ||
|
|
|
+@gtcooke94 to review the advancedtls changes. |
gtcooke94
approved these changes
Apr 22, 2024
dfawley
approved these changes
Apr 23, 2024
dfawley
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|| :to grep. This is because grep returns error when there are no lines found.Basically, fixes #7141
RELEASE NOTES: none