Skip to content

chore: fix lint #7133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2024
Merged

chore: fix lint #7133

merged 3 commits into from
Apr 16, 2024

Conversation

@arvindbr8
Copy link
Contributor

@arvindbr8 arvindbr8 commented Apr 16, 2024 •
edited
Loading

Couple of changes:

  1. provide a comment for service methods in cmd/protoc-gen-go-grpc/testdata/golden.proto
  2. rename reflection/test/serverrefletion_test.go 's package to test_test

RELEASE NOTES: none

@arvindbr8 arvindbr8 requested a review from dfawley April 16, 2024 21:00
@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Apr 16, 2024
@arvindbr8 arvindbr8 added this to the 1.64 Release milestone Apr 16, 2024
@arvindbr8 arvindbr8 merged commit 0c6d80c into grpc:master Apr 16, 2024
1 check passed
@arvindbr8 arvindbr8 deleted the fix_reflection_test branch May 30, 2024 00:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels

Type: Internal Cleanup Refactors, etc

Projects

None yet

Milestone

1.64 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@arvindbr8 @dfawley