Skip to content

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Nov 27, 2023

One of these came up in the review of PR 6726 after it was merged. I made a pass through the file and cleaned up all the logs that I thought deserved a cleanup.

RELEASE NOTES: none

@easwars easwars requested a review from zasweq November 27, 2023 19:57
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Nov 27, 2023
@easwars easwars added this to the 1.61 Release milestone Nov 27, 2023
@codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #6820 (2678e48) into master (02ea031) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6820      +/-   ##
==========================================
- Coverage   83.45%   83.39%   -0.06%     
==========================================
  Files         285      285              
  Lines       30879    30879              
==========================================
- Hits        25770    25752      -18     
- Misses       4039     4053      +14     
- Partials     1070     1074       +4     
Files Coverage Δ
xds/internal/server/listener_wrapper.go 68.03% <0.00%> (ø)

... and 15 files with indirect coverage changes

Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq assigned easwars and unassigned zasweq Nov 29, 2023
@easwars easwars merged commit 737f87b into grpc:master Nov 29, 2023
@easwars easwars deleted the xds_server_cleanup_formatting_directives branch November 29, 2023 21:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants