Skip to content

Conversation

@arvindbr8
Copy link
Contributor

@arvindbr8 arvindbr8 commented Oct 3, 2023

Fixes: #1676

Codecov Reach graph - https://app.codecov.io/github/grpc/grpc-go/tree/code_coverage

RELEASE NOTES: none

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@arvindbr8 arvindbr8 added the Type: Meta Github repo, process, etc label Oct 3, 2023
@arvindbr8 arvindbr8 added this to the 1.59 Release milestone Oct 3, 2023
@arvindbr8
Copy link
Contributor Author

Discussed offline. I've made a few changes since the last push.

We had a cumulative problem of go test --cover only covering unit tests. It did not include coverage from e2e style tests. For this adding coverpkg=./... worked which includes coverage of tests

Since most of the changes are to the main module, it makes sense to limit the scope of presubmit check to only run go test --cover for the main module.

Ignored the following paths in codecov.

  • "test/"
  • "benchmark/"
  • "internal/testutils"
  • ".*.pb.go"

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Oct 4, 2023
@arvindbr8 arvindbr8 changed the title github: add code coverage github: add code coverage with codecov.io Oct 4, 2023
@arvindbr8 arvindbr8 merged commit 39972fd into grpc:master Oct 4, 2023
@arvindbr8 arvindbr8 deleted the code_coverage branch October 11, 2023 20:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Meta Github repo, process, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable coverage reporting

3 participants