Skip to content

Revert "status: fix/improve status handling (#6662)" #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

Revert "status: fix/improve status handling (#6662)" #6673

merged 1 commit into from
Oct 2, 2023
+44 −270

Conversation

@dfawley
Copy link
Member

@dfawley dfawley commented Oct 2, 2023 •
edited
Loading

This reverts commit 0772ed7

We found some usages that were relying on the illegal behavior we had before. We'll work to get those resolved then roll this forward again.

RELEASE NOTES: none

@dfawley dfawley added this to the 1.59 Release milestone Oct 2, 2023
@dfawley dfawley requested a review from ginayeh October 2, 2023 18:36
@dfawley dfawley merged commit 9e1fc3e into grpc:master Oct 2, 2023
1 check passed
@dfawley dfawley deleted the statusrb branch October 2, 2023 19:52
dfawley added a commit to dfawley/grpc-go that referenced this pull request Oct 2, 2023
@dfawley
Reapply "status: fix/improve status handling (grpc#6662)" (grpc#6673)
9774dcd 
This reverts commit 9e1fc3e.
dfawley added a commit to dfawley/grpc-go that referenced this pull request Oct 4, 2023
@dfawley
Reapply "status: fix/improve status handling (grpc#6662)" (grpc#6673)
dc81128 
This reverts commit 9e1fc3e.

It removes the part of the commit that forces status codes out of range to be
converted to UNKNOWN, however.
dfawley added a commit to dfawley/grpc-go that referenced this pull request Oct 4, 2023
@dfawley
Reapply "status: fix/improve status handling (grpc#6662)" (grpc#6673)
12727c3 
This reverts commit 9e1fc3e.

It removes the part of the commit that forces status codes out of range to be
converted to UNKNOWN, however.
dfawley added a commit that referenced this pull request Oct 5, 2023
@dfawley
Reapply "status: fix/improve status handling (#6662)" (#6673) (#6688)
e3f1514
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@easwars easwars easwars approved these changes

@ginayeh ginayeh Awaiting requested review from ginayeh

Assignees

@ginayeh ginayeh

Labels

Type: Bug

Projects

None yet

Milestone

1.59 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@dfawley @easwars @ginayeh