Skip to content

Deprecate WithBlock and WithReturnConnectionError #7095

@pellared

Description

@pellared

Use case(s) - what problem will this feature solve?

#7029 has deprecated Dial and DialContext.
NewClient ignores WithBlock, WithTimeout, WithReturnConnectionError.

grpc.WithTimeout is already deprecated.

WithBlock and WithReturnConnectionError have a GoDoc comment which discourages its usage.

Proposed Solution

Deprecate WithBlock and WithReturnConnectionError so to better notify that these options should not be used and additionally that they are ignored by NewClient.

Deprecation is more visible in https://pkg.go.dev/google.golang.org/grpc and more usable for static analysis tools such as golangci-lint.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions