Add .editorconfig and fix warnings #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
ReubenBond,
amcasey and
mgravell
BrennanConroy
approved these changes
Feb 24, 2023
Contributor
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
You could instead consider using the runtimes version:
https://github.com/dotnet/runtime/blob/main/eng/CodeAnalysis.src.globalconfig
Member
Author
|
I prefer sticking closer to the ASP.NET Core one because we understand it more and it's easier to keep them in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editorconfig is copied from dotnet/aspnetcore