Skip to content

Check styles declaration against MUI Theme with TypeScript #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 18, 2025
Merged

Check styles declaration against MUI Theme with TypeScript #855

merged 9 commits into from
Sep 18, 2025

Conversation

@Tristan-WorkGH
Copy link
Contributor

Fix styles definitions by telling typescript to check against MUI Theme declaration.

Create type to reuse everywhere.

@Tristan-WorkGH Tristan-WorkGH self-assigned this Sep 15, 2025
This was referenced Sep 15, 2025
Merged
Merged
Merged
Merged
sBouzols
sBouzols approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@sBouzols sBouzols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review OK
Tests OK
Console warning check ok

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Tristan-WorkGH Tristan-WorkGH merged commit 5448489 into main Sep 18, 2025
5 checks passed
@Tristan-WorkGH Tristan-WorkGH deleted the fix-mui-theme branch September 18, 2025 08:17
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Sep 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sBouzols sBouzols sBouzols approved these changes

Assignees

@Tristan-WorkGH Tristan-WorkGH

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tristan-WorkGH @sBouzols