Support proxy protocol for loadbalancer backends #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadbalancer.go
Outdated
| Host string `json:"host"` | ||
|
|
||
| // Proxy protocol version | ||
| ProxyProtocol string `json:"proxy_protocol,omitempty"` |
Member
There was a problem hiding this comment.
This should be of type *string. The reason is that when we want to remove ProxyProtocol (by setting it to empty) via a loadbalancer update request, the empty ProxyProtocol is omitted in the request's payload => the value of ProxyProtocol is not removed.
itakouna
force-pushed
the
feature/GD-12234
branch
from
62bf3a3 to
2d3886a
Compare
Member
|
LGTM |
nvthongswansea
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.