Skip to content

qt: Prevent pasting (no label) as label in consolidation transaction #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2021
Merged

qt: Prevent pasting (no label) as label in consolidation transaction #2255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/qt/sendcoinsdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,6 @@ void SendCoinsDialog::coinControlConsolidateWizardButtonClicked()

void SendCoinsDialog::selectedConsolidationRecipient(SendCoinsRecipient consolidationRecipient)
{
LogPrintf("INFO: %s: SLOT called.", __func__);

ui->coinControlChangeCheckBox->setChecked(true);
ui->coinControlChangeEdit->setText(consolidationRecipient.address);

Expand All @@ -505,6 +503,12 @@ void SendCoinsDialog::selectedConsolidationRecipient(SendCoinsRecipient consolid
}
}

// The AddressTableModel substitutes the translated "(no label)" when the label is empty. If we use
// that here, we will end up pasting a literal lable of "(no label)". Because the translation (tr) should
// be consistent between here and the AddressTableModel::data, it should match the conditional and be put
// back to the desired empty QString.
if (consolidationRecipient.label == tr("(no label)")) consolidationRecipient.label = QString();

pasteEntry(consolidationRecipient);
}

Expand Down