Refactor QT UI variable names to be more consistent, Fix Difficulty default #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set to "N/A" like all other default labels
Inherit changed from Bitcoin: bitcoin/bitcoin@9155241
Type of widget should always be in variable name Always attempt to put widget type at end of name Enforce consistent camelCase Fix meta variable names (labelLabel) Many UI variables (payTo, port, lang) were named too generically to be changed by me. Someone with more expertise in the C++ side of the hooks will need to review which can be safely changed without breaking functionality.
This reverts commit 51d0857.
sorry travis
cyrossignol
approved these changes
Oct 9, 2019
jamescowens
approved these changes
Oct 10, 2019
barton2526
commented
Oct 11, 2019
| // toggle tree/list mode | ||
| connect(ui->radioTreeMode, SIGNAL(toggled(bool)), this, SLOT(radioTreeMode(bool))); | ||
| connect(ui->radioListMode, SIGNAL(toggled(bool)), this, SLOT(radioListMode(bool))); | ||
| connect(ui->treeModeRadioButton, SIGNAL(toggled(bool)), this, SLOT(treeModeRadioButton(bool))); |
Member
Author
There was a problem hiding this comment.
there is a critical error in this PR here. I believe the SLOT should not have been changed
Member
Author
|
This change: 68361f2 fixes the bold status text. It was a simple css change (thanks @cyrossignol !) |
Member
Author
|
See #1565 for fixes |
jamescowens
added a commit
that referenced
this pull request
Oct 22, 2019
Added - Add testnet desktop launcher action for Linux #1516 (@caraka) - Shuffle vSideStakeAlloc if necessary to support sidestaking to more than 6 destinations #1532 (@jamescowens) - New Superblock format preparations for Fern #1526, #1542 (@jamescowens, @cyrossignol) - Multisigtools - Consolidate multisig unspent #1529 (@iFoggz) - Scanforunspent #1547 (@iFoggz) - consolidatemsunspent and scanforunspent bug fix #1561 (@iFoggz) - New banning misbehavior handling and Peers Tab on Debug Console #1537 (@jamescowens) - Reimplement getunconfirmedbalance rpc #1548 (@jamescowens) - Add CLI switch to display binary version #1553 (@cyrossignol) Changed - Select smallest coins for contracts #1519 (@iFoggz) - Move some functionality from miner to SelectCoinsForStaking + Respect the coin reserve setting + Randomize UTXO order #1525 (@iFoggz) - For voting - if url does not contain http then add it #1531 (@iFoggz) - Backport newer serialization facilities from Bitcoin #1535 (@cyrossignol) - Refactor ThreadSocketHandler2() Inactivity checks #1538 (@iFoggz) - Update outdated checkpoints #1539 (@barton2526) - Change needed to build Gridcoin for OSX using homebrew #1540 (@Git-Jiro) - Optimize scraper traffic for expiring manifests #1542 (@jamescowens) - Move legacy neural vote warnings to debug log level #1560 (@cyrossignol) - Change banlist save interval to 5 minutes #1564 (@jamescowens) - Change default rpcconsole.ui window size to better support new Peers tab #1566 (@jamescowens) Removed - Remove deprecated RSA weight and legacy kernel #1507 (@cyrossignol) Fixed - Clean up compiler warnings #1521 (@cyrossignol) - Handle missing external CPID in client_state.xml #1530 (@cyrossignol) - Support boost 1.70+ #1533 (@iFoggz) - Fix diagnostics failed to make connection to NTP server #1545 (@Git-Jiro) - Install manpages in correct system location #1546 (@Git-Jiro) - Fix ability to show help and version without a config file #1553 (@cyrossignol) - Refactor QT UI variable names to be more consistent, Fix Difficulty default #1563 (@barton2526) - Fix two regressions in previous UI refactor #1565 (@barton2526) - Fix "Owed" amount in output of "magnitude" RPC method #1569 (@cyrossignol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of widget should always be in variable name
Always attempt to put widget type at end of name
Enforce consistent camelCase
Fix meta variable names (labelLabel)
Many UI variables (payTo, port, lang) were named too generically to be changed by me. Someone with more expertise in the C++ side of the hooks will need to review which can be safely changed without breaking functionality.
Fix Difficulty defaulting to 1
Set to "N/A" like all other default labels