Update tests to match swapi.dev #181
Merged
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWAPI returns 82 instead of 87 https://swapi.dev/api/people
There are 6 films https://swapi.dev/api/films/
* Language for https://swapi.dev/api/species/4 * `Wookie`
| @@ -99,7 +99,7 @@ describe('Film type', async () => { | |||
| '{ allFilms { edges { cursor, node { ...AllFilmProperties } } } }', | |||
| ); | |||
| const result = await swapi(query); | |||
| expect(result.data.allFilms.edges.length).to.equal(7); | |||
| expect(result.data.allFilms.edges.length).to.equal(6); | |||
There was a problem hiding this comment.
Can you investigate why we have one less film?
It should be the opposite.
There was a problem hiding this comment.
Can you please check if it related to #172 or happened for some other reason?
There was a problem hiding this comment.
I think that there were only 6 movies in original too. I checked the data source file from swapi.co
This makes sense if we look at commit history of the file, Episode VII – The Force Awakens was released in 2015 and the last time the owner update things was 6 years ago (2014) and didn’t really touched them (except to fix typos) so it makes sense since there were only 6 movies.
swapi.dev has issue open Juriy/swapi#8 to update movies
saihaj
commented
Sep 7, 2020
| species: { name: 'Human' }, | ||
| species: null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests assertion values were little out of sync from what SWAPI returned so updated those values.
Note: Use
yarn coverto run tests becauseyarn testfails at the moment because Flow is broken. Alsoyarn coverallsisn't working and will fix it once we switch to NPM #180 and update deps